I want to do a warrior class, but I need help on deciding what race is best and what proffesions I should have (I may have gotten the word wrong but I mean like Engineering etc.) I want to be able to save money easily, and deal major damage, so I'm wondering if a blacksmithing class would be good? I can't remember now but can Night Elves be warriors, if so, is that a good choice? Get back to me on this one.

All races can be Warriors.

I went with a Orc.

Mining/Smithing (Armor or Weapons smithing)Saves you money by making your own armor/weapons....

Herb/Alch is what im doing I May switch to Smithing.

But if you want to do Smithing i would say just Mine till after you get you mount.

HAH....the most gear dependent class in the game.  Good luck on money.  Mining wont cut it cause you really need to level your trade too...and ores get scarce from small thorium on up. 

Here is a major problem:
First it is your first main...so you dont have a farming character nor tradeskills to make loot. So now you have to spend money that you really dont want to on Repairs,Gear,Training, and misc things.

For a first character you have chosen the job with the biggest repair bill...especially when you start wearing rare or epics.....

The good news is warriors are needed in groups.  So you should level up pretty well and get into some groups for kick ass gear.  Worry about money at 60.

Only advise is dont spend if you dont need to....Wear what you find...and at lvl 30-40 refuse to purchase from the auction house.....if you want a horse by 40.  This rule of thumb I preach to all new players in guild...everyone has a horse by 40 in the guild....but one person...he spent his cash after 30....kicking himself at 45 right now.